improvement(tests): db-mock migration tranche 3 — lib/workflows, lib/copilot remainder, ee/core/misc#5864
Conversation
…copilot remainder, ee/core/misc
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Coverage spans EE (permission checks, workspace forking cleanup/unlink), lib/workflows (deploy, lifecycle, duplicate, schedules, deployment outbox, execution state, skills), lib/copilot (chat, stream liveness, agent URL, knowledge/tools), plus auth/ban, admin, BYOK, outbox, idempotency cleanup, organizations, uploads, and workspace admin-move. Tests now queue rows by schema table and assert via
No production/runtime behavior changes—only test setup and assertions. Reviewed by Cursor Bugbot for commit 1000474. Configure here. |
Greptile SummaryThis PR moves 27 test suites onto the shared database mock utilities. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "improvement(tests): use the shared notLi..." | Re-trigger Greptile |
Summary
vi.mock('@sim/db', <factory>)implementations onto the shareddbChainMock+queueTableRowsAPI — net ~−760 lines (tranche 3; tranches 1–2 were improvement(tests): db-mock migration tranche 1 — knowledge, billing/org, workflows/background #5861/improvement(tests): db-mock migration tranche 2 — copilot, mothership, workspaces, connectors, mcp #5863, mock consolidation improvement(testing): consolidate @sim/db mocks into one table-aware chain mock #5856)lib/workflows/**remainder (deployment-outbox, lifecycle, schedules, persistence/duplicate, orchestration, executor, skills),lib/copilot/**remainder (chat, server, request, server tools — removes the workspace-context polluter),ee/**+lib/coreoutbox/idempotency +lib/auth/ban+lib/admin,lib/workspacespolicy/admin-move, uploads error suiteType of Change
Testing
Full apps/sim suite green locally (13704/13705; sole failure is the known local ripgrep dependency, green in CI). Every file verified standalone, per-cluster, and with neighbor sweeps (lib/workflows 985 tests, lib/copilot 900, ee/workspaces/admin/core 749). tsc + biome clean.
Checklist